Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor utility function and add contentType ID #9714

Merged
merged 5 commits into from
Dec 1, 2021
Merged

Refactor utility function and add contentType ID #9714

merged 5 commits into from
Dec 1, 2021

Conversation

nicola-d-bbc
Copy link
Contributor

@nicola-d-bbc nicola-d-bbc commented Dec 1, 2021 •
edited
Loading

Resolves #NUMBER

Overall change:
Use contentType value to make aria-labelledby and ID more unique to avoid a11y tests duplication failures, and added more tests to ID creation function.

Fixes issues caused on latest by #9598

Code changes:

  • Refactored getLinkID function and moved to utilities in StoryPromo
  • Created new unit tests for refactored function, and refactored existing tests
  • Added contentType value to ID to make it more unique
  • I have assigned myself to this PR and the corresponding issues
  • I have added the cross-team label to this PR if it requires visibility across World Service teams
  • I have assigned this PR to the Simorgh project
  • (BBC contributors only) This PR follows the repository use guidelines

Testing:

  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive)
  • This PR requires manual testing

@nicola-d-bbc nicola-d-bbc self-assigned this Dec 1, 2021
MuhammadAHussain
MuhammadAHussain approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@MuhammadAHussain MuhammadAHussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nicola-d-bbc nicola-d-bbc merged commit 5ffcf62 into latest Dec 1, 2021
@nicola-d-bbc nicola-d-bbc deleted the a11y-bug-fix branch December 1, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MuhammadAHussain MuhammadAHussain MuhammadAHussain approved these changes

@ryanmccombe ryanmccombe ryanmccombe approved these changes

@HarveyPeachey HarveyPeachey HarveyPeachey approved these changes

Assignees

@nicola-d-bbc nicola-d-bbc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicola-d-bbc @HarveyPeachey @ryanmccombe @MuhammadAHussain