Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ATI Optimo contentId logic after Ares change #9717

Merged
merged 8 commits into from
Dec 3, 2021
Merged

Update ATI Optimo contentId logic after Ares change #9717

merged 8 commits into from
Dec 3, 2021

Conversation

rebeccamcginn
Copy link
Contributor

@rebeccamcginn rebeccamcginn commented Dec 2, 2021 •
edited
Loading

Resolves #9607

Overall change:
This PR removes the logic used to construct the contentId for Optimo articles, as Ares now provide the value for us.

Code changes:

  • Updated Optimo getContentId function to use the contentId provided by Ares
  • Updated/added contentId to test data
  • I have assigned myself to this PR and the corresponding issues
  • I have added the cross-team label to this PR if it requires visibility across World Service teams
  • I have assigned this PR to the Simorgh project
  • (BBC contributors only) This PR follows the repository use guidelines

Testing:

  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive)
  • This PR requires manual testing

@rebeccamcginn rebeccamcginn self-assigned this Dec 2, 2021
ryanmccombe
ryanmccombe approved these changes Dec 2, 2021
View reviewed changes
src/app/lib/analyticsUtils/article/index.js Outdated Show resolved Hide resolved
@rebeccamcginn @ryanmccombe
Update src/app/lib/analyticsUtils/article/index.js
f6fd55d 
Co-authored-by: Ryan McCombe <ryanmccombe@gmail.com>
@rebeccamcginn rebeccamcginn merged commit 9776ad5 into latest Dec 3, 2021
@rebeccamcginn rebeccamcginn deleted the optimo-contentId branch December 3, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amoore108 amoore108 amoore108 approved these changes

@ryanmccombe ryanmccombe ryanmccombe approved these changes

Assignees

@rebeccamcginn rebeccamcginn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rebeccamcginn @ryanmccombe @amoore108