-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message type is not exposed #384
Comments
I'm not sure this is actually required, as you need to install sqs-client anyway, it's realistically not that different or better from doing this:
I'll have a think on it, we did used to do it, but that was when we were adjusting the type ourselves. |
I'm a bit confused because the Because of this, I'm not required to install the pkg separately. |
As of version 7 of npm, peer dependencies are also auto installed, but either way, you still need to install it yeah. |
Exactly, so I don't have to add IMO sqs-consumer should either enforce the installation of |
Well no, the use case of needing the Message type is not that great (we haven't been exporting it for about half a year). I'm not sure that it's that big of an ask for the user to import it directly themselves honestly, it's not something we're ever going to modify. This isn't a bug either btw, so I'm gonna change the labelling. |
This has sort of been done in #385 I'm not happy with it though due to the docs issues. Thinking about the time I have available, I'm going to decide not to do this, if anyone would still like to do this, feel free to open a new pr with the documentation fixed. |
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Describe the bug
AWS Message type is not re-exported from the package.
Most of the functions (e.g.: handleMessage operate with this type and it would be good to use it after installing sqs-consumer.
Your minimal, reproducible example
Steps to reproduce
Expected behavior
As a user I'd like to provide type safety by importing
Message
type.How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
Package version
AWS SDK version
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: