Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-export message interface #385

Closed
wants to merge 1 commit into from
Closed

Conversation

nicholasgriffintn
Copy link
Member

Resolves #384

Description:

It has been suggested that the package would be easier to use for developers if the library re-exported the AWS interface Message, so that they don't have to import it from the AWS library directly.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Why is this change required?:

This PR re-exports the interface from the types file and also changes how we use the interface internally to also use that export.

Code changes:

  • Changed the type exports to export at the end of the file rather than individually (this allows us to do the next item)
  • Re export the Message type from the AWS SDK

@nicholasgriffintn nicholasgriffintn requested review from a team as code owners April 10, 2023 16:26
@codeclimate
Copy link

codeclimate bot commented Apr 10, 2023

Code Climate has analyzed commit 2445f99 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 94.7% (0.0% change).

View more on Code Climate.

@nicholasgriffintn
Copy link
Member Author

So the problem with this is that the docs are blank, this means that our typedoc links to the type but nothing is displayed.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Message type is not exposed
1 participant