Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating advice on message processing #366

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

nicholasgriffintn
Copy link
Member

Resolves #256

Description:

Updated the advice on message processing to make it clearer how to ensure messages are processed one at a time and that messages can be acknowledged.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Why is this change required?:

It was previously unclear how this functionality works, updating the README makes this clearer.

Code changes:

  • Updated the README

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codeclimate
Copy link

codeclimate bot commented Feb 15, 2023

Code Climate has analyzed commit 58d8bf6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 94.5% (0.0% change).

View more on Code Climate.

@nicholasgriffintn nicholasgriffintn merged commit c2ceb55 into main Feb 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2023
@nicholasgriffintn nicholasgriffintn deleted the polling-advice-update branch February 15, 2023 23:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poller processing next message before previous message has finished
1 participant