Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme : create custom producer with accessKeyId / secretAccessKey #75

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

cokia
Copy link
Contributor

@cokia cokia commented Dec 7, 2022

Description

Update Readme.md

  • At Usage (create custom producer)
    In the previous version of readme, use accessKeyId and secretAccessKey inside of parameter at Producer.create
    but code implementation are doesn't use accessKeyId and secretAccessKey parameter.

So, I changed readme to use SQS parameter and AWS.config.update

Motivation and Context

Based on Issue #63

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

README.md Outdated Show resolved Hide resolved
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants