Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adr: Add non-permanent deletion ADR proposal #21

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

samdbmg
Copy link
Member

@samdbmg samdbmg commented Feb 5, 2024

Details

Adds a draft ADR document around whether deletion of Flows should set an is_deleted flag instead of actually removing the object.

This ADR is a draft for discussion, and intended to set out the options without yet indicating a decision. I'd appreciate comments and thoughts around this to guide us towards a decision on this one.

Pivotal Story (if relevant)

Story URL: https://www.pivotaltracker.com/story/show/186711186

Related PRs

N/A

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Pivotal story (if relevant)
  • Follow-up stories added to Pivotal

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

@samdbmg samdbmg requested a review from a team February 5, 2024 13:55
Adds notes from discussion about content deletion ADR, and outcome of
rejecting it.
@samdbmg samdbmg marked this pull request as ready for review February 16, 2024 16:06
Copy link
Contributor

@philipnbbc philipnbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samdbmg samdbmg merged commit 94c8ebc into main Feb 21, 2024
3 checks passed
@samdbmg samdbmg deleted the sammg-deletion-flags-adr branch February 21, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants