Consolidate timerange naming #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipnbbc
force-pushed
the
philipn-consolidate-timeranges
branch
from
c969293
to
6acd7f7
Compare
AndrewGibb
requested changes
Feb 16, 2024
philipnbbc
force-pushed
the
philipn-consolidate-timeranges
branch
from
6acd7f7
to
bbfc0ca
Compare
Updated in 3f97990 based on your suggested change. |
philipnbbc
force-pushed
the
philipn-consolidate-timeranges
branch
from
bbfc0ca
to
1b8ca48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR removes redundant timerange properties (
last_ts,first_ts,exclusive_last_ts) from FlowSegment, renames FlowSegmentrangetotimerangeand renames "time range" etc. to "timerange" in the text.Pivotal Story (if relevant)
Story URL: https://www.pivotaltracker.com/story/show/186711366
Related PRs
Where appropriate. Indicate order to be merged.
Submitter PR Checks
(tick as appropriate)
Reviewer PR Checks
(tick as appropriate)
Info on PRs
The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.