Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what a sample is for FlowSegment sample_offset/count #29

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

philipnbbc
Copy link
Contributor

Details

This PR adds some description text to clarify what is meant by a sample is in the definition of the FlowSegment sample_offset and sample_count properties.

Note that there is a general discussion about whether FlowSegment should reference the coded media units or presentation media units. The result of that discussion may be that the definition and naming of these properties changes.

Pivotal Story (if relevant)

Story URL:

Related PRs

Where appropriate. Indicate order to be merged.

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Pivotal story (if relevant)
  • Follow-up stories added to Pivotal

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

@philipnbbc philipnbbc marked this pull request as ready for review February 21, 2024 11:30
@philipnbbc philipnbbc requested a review from a team as a code owner February 21, 2024 11:30
@philipnbbc philipnbbc merged commit d45c1af into main Feb 21, 2024
3 checks passed
@philipnbbc philipnbbc deleted the philipn-flow-segment-sample-range-note branch February 21, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants