Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AN-0002 First Draft #50

Merged
merged 2 commits into from
May 7, 2024
Merged

AN-0002 First Draft #50

merged 2 commits into from
May 7, 2024

Conversation

C-Lunn
Copy link
Contributor

@C-Lunn C-Lunn commented May 2, 2024

Details

Adds AN-0002: Timing in MPEG-TS

Pivotal Story (if relevant)

Story URL: https://www.pivotaltracker.com/story/show/187412238

Related PRs

Where appropriate. Indicate order to be merged.

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Pivotal story (if relevant)
  • Follow-up stories added to Pivotal

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

@C-Lunn C-Lunn requested a review from a team as a code owner May 2, 2024 12:18
@C-Lunn C-Lunn force-pushed the calluml-an-0002 branch 5 times, most recently from 56af291 to f46c186 Compare May 2, 2024 13:28
Copy link
Contributor

@philipnbbc philipnbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits and otherwise LGTM

docs/appnotes/0002-Timing-in-MPEG-TS.md Outdated Show resolved Hide resolved
docs/appnotes/0002-Timing-in-MPEG-TS.md Outdated Show resolved Hide resolved
@C-Lunn C-Lunn merged commit 7669824 into main May 7, 2024
3 checks passed
@C-Lunn C-Lunn deleted the calluml-an-0002 branch May 7, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants