Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application note regarding independently decodable segments #54

Merged
merged 2 commits into from
May 8, 2024

Conversation

j616
Copy link
Contributor

@j616 j616 commented May 8, 2024

Details

Add application note regarding independently decodable segments

Pivotal Story (if relevant)

Story URL: https://www.pivotaltracker.com/story/show/187412231

Related PRs

Where appropriate. Indicate order to be merged.

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Pivotal story (if relevant)
  • Follow-up stories added to Pivotal

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

@j616 j616 requested a review from a team as a code owner May 8, 2024 10:00
@philipnbbc philipnbbc self-assigned this May 8, 2024
Copy link
Contributor

@philipnbbc philipnbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This provides good info. I had 2 nits and otherwise LGTM.

docs/appnotes/0005-indepentent-segments.md Outdated Show resolved Hide resolved
docs/appnotes/0005-indepentent-segments.md Outdated Show resolved Hide resolved
docs/appnotes/0005-indepentent-segments.md Show resolved Hide resolved
@j616 j616 merged commit f8b5801 into main May 8, 2024
3 checks passed
@j616 j616 deleted the jamessa-indDecode branch May 8, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants