Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing 403 responses related to ADR-0005 #61

Merged
merged 3 commits into from
May 31, 2024
Merged

Add missing 403 responses related to ADR-0005 #61

merged 3 commits into from
May 31, 2024

Conversation

j616
Copy link
Contributor

@j616 j616 commented May 31, 2024

Details

Add missing 403 responses related to ADR-0005 "Flow Read-Write Permissions"

Pivotal Story (if relevant)

Story URL: https://www.pivotaltracker.com/story/show/187554185

Related PRs

Original PR which added read-only functionality #24

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Pivotal story (if relevant)
  • Follow-up stories added to Pivotal

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

@j616 j616 requested a review from a team as a code owner May 31, 2024 11:21
Copy link
Contributor

@philipnbbc philipnbbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j616 j616 merged commit 45a8fcd into main May 31, 2024
5 checks passed
@j616 j616 deleted the jamessa-403 branch May 31, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants