Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appnote: add populating source metadata app note #66

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

philipnbbc
Copy link
Contributor

Details

This PR adds an application note about populating Source metadata from Flow metadata.

Pivotal Story (if relevant)

Story URL: https://www.pivotaltracker.com/story/show/187609488

Related PRs

Where appropriate. Indicate order to be merged.

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Pivotal story (if relevant)
  • Follow-up stories added to Pivotal

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

@philipnbbc philipnbbc requested a review from a team as a code owner June 17, 2024 09:49
Copy link
Member

@samdbmg samdbmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - couple of nits inlined

docs/appnotes/0007-populating-source-metadata.md Outdated Show resolved Hide resolved
docs/appnotes/0007-populating-source-metadata.md Outdated Show resolved Hide resolved
docs/appnotes/0007-populating-source-metadata.md Outdated Show resolved Hide resolved
philipnbbc and others added 4 commits June 17, 2024 13:07
Co-authored-by: Sam Mesterton-Gibbons <sam.mesterton-gibbons@bbc.co.uk>
Co-authored-by: Sam Mesterton-Gibbons <sam.mesterton-gibbons@bbc.co.uk>
@philipnbbc philipnbbc force-pushed the philipn-source-flow-metadata branch from 7fb0065 to 1c29422 Compare June 17, 2024 12:07
@philipnbbc philipnbbc merged commit 6dfcb52 into main Jun 17, 2024
5 checks passed
@philipnbbc philipnbbc deleted the philipn-source-flow-metadata branch June 17, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants