Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Stoplight Elements for docs render #8

Merged
merged 5 commits into from
Dec 20, 2023

Conversation

samdbmg
Copy link
Member

@samdbmg samdbmg commented Dec 19, 2023

Details

Switches documentation render to Stoplight Elements, which pulls out and renders internal types (e.g. Timestamp and TimeRange), and better aligns with what we're doing internally.

Also switches to Stoplight Spectral for documentation linting, again for internal alignment and to reduce the number of tools in use.

Pivotal Story

Story URL: https://www.pivotaltracker.com/story/show/186709535

Related PRs

Followed by #9

Links to external test runs/working deployment

N/A

Submitter PR Checks

(tick as appropriate)

  • Added bbc/rd-apmm-cloudfit team as a reviewer
  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • New features and API breaks are flagged in commit messages using magic strings
  • Repo maintainer is notified that a release is required
  • Documentation updated (README, Confluence, Docstrings, API spec, Engineering Guide, etc.)
  • Downstream repos have been checked for potential breaks & fixed as needed
  • APIs/UIs/CLIs updated as required
  • PR added to Pivotal story
  • Follow-up stories added to Pivotal
  • Any temporary code/configuration removed (e.g. test deployment environment, temporary commontooling branch)
  • Any pins against pre-releases have been removed

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Tests exercise code appropriately
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on Cloudfit PRs

@samdbmg samdbmg requested a review from a team December 19, 2023 10:40
@samdbmg samdbmg mentioned this pull request Dec 19, 2023
18 tasks
@samdbmg samdbmg marked this pull request as ready for review December 19, 2023 13:31
@samdbmg samdbmg marked this pull request as draft December 19, 2023 13:46
@samdbmg
Copy link
Member Author

samdbmg commented Dec 19, 2023

Switching back to Draft - there's one endpoint that doesn't quite work here due to Redocly/redocly-cli#792

@samdbmg samdbmg marked this pull request as ready for review December 19, 2023 14:02
Copy link
Contributor

@GeorginaShippey GeorginaShippey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a couple of broken links in the docs - LGTM

README.md Show resolved Hide resolved
Switches to Stoplight Elements to render HTML version of API spec
Makes the "Try It" box rendered in the documentation default to using
the mock API that this repo can start.
Adds missing titles to some types so they appear in the render.
Also removes some spurious whitespace.
Adds a script to rewrite part of the bundled API spec, to work around
Redocly not having support for `patternProperties` (see also bug
Redocly/redocly-cli#792)
@samdbmg samdbmg merged commit b557c46 into main Dec 20, 2023
3 checks passed
@samdbmg samdbmg deleted the sammg-use-stoplight-elements branch December 20, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants