Check for missing image #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the issue is because Phantom failed. Maybe we should try and figure out why it is failing to render? Also, if we notice an image is missing when we are running through the whole process, could we get wraith to run again for the scenarios that relate to the missing images? E.G. The filenames are in a consistent format: |
|
This will be fixed by #112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When phantom fails to capture an image, it means there are an odd number of images in the folder which causes cropping issues such as #99. The intention is to check for an even number of images in each folder, then add a standard image to ensure cropping doesn't fail.