Skip to content

Conversation

dnlbaines
Copy link
Contributor

@dnlbaines dnlbaines commented Jun 20, 2019

This adds a polyfill to allow us to create CustomEvents. A CustomEvent is now fired when a file is dropped into the load dialog.

@microbit-carlos
Copy link
Collaborator

@danbai02 Did you test this in IE10?
https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/

@dnlbaines
Copy link
Contributor Author

@danbai02 Did you test this in IE10?
https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/

I have not, I develop in an Ubuntu VM which makes this harder. I usually use IETab but that does not seem to work with drag and drop.

@microbit-carlos
Copy link
Collaborator

Can you run it in an IE10 vm? You can probably just download the zip file inside the windows VM and test it from there: https://github.com/danbai02/PythonEditor/archive/master.zip
With the default networking in virtualbox I normally serve from the host and then in the VM just go to the host ip (easy to spot using ifconfig or ipconfig) , although i am not sure if that would still work if you are serving from a different vm.

@dnlbaines
Copy link
Contributor Author

Can you run it in an IE10 vm? You can probably just download the zip file inside the windows VM and test it from there: https://github.com/danbai02/PythonEditor/archive/master.zip
With the default networking in virtualbox I normally serve from the host and then in the VM just go to the host ip (easy to spot using ifconfig or ipconfig) , although i am not sure if that would still work if you are serving from a different vm.

Confirmed working in IE10.

Copy link
Collaborator

@microbit-carlos microbit-carlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @danbai02!

@microbit-carlos microbit-carlos merged commit 748f4ff into bbcmicrobit:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants