Skip to content

UI: Style <hr> inside WebUSB modals. #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2019
Merged

UI: Style <hr> inside WebUSB modals. #259

merged 1 commit into from
Oct 10, 2019

Conversation

microbit-carlos
Copy link
Collaborator

Before After
image image
image image

@microbit-carlos
Copy link
Collaborator Author

@microbit-henry could you review please?

@microbit-carlos microbit-carlos self-assigned this Oct 10, 2019
@microbit-henry
Copy link
Contributor

I agree it looks better with the shorter, yellow hr. I dont think the display: block; line is necessary though? Chrome seems to set that by default.

@microbit-carlos
Copy link
Collaborator Author

Just in case other browsers set that differently.

@microbit-carlos microbit-carlos merged commit 9883146 into v2-beta Oct 10, 2019
@microbit-carlos microbit-carlos deleted the webusb-error-modal-hr branch October 10, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@microbit-henry microbit-henry microbit-henry approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@microbit-carlos microbit-carlos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@microbit-carlos @microbit-henry