Target and render icons in Firefox #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microbit-josephine Could you include a before and after screenshot in this PR, will make the reviewing easier. |
|
Before: |
microbit-henry
approved these changes
Oct 18, 2019
|
@microbit-henry what browsers was this tested on? |
|
@microbit-carlos I tested it in windows firefox, IE10 and IE11. All the buttons worked in firefox, only the buttons that were too low were fixed in IE10 and none of the buttons were fixed in IE11. But I assumed this wasn't an issue because this was a PR specifically for fixing the buttons in windows firefox |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.