Skip to content

Conversation

Era-Dorta
Copy link
Contributor

@Era-Dorta Era-Dorta commented Aug 27, 2025

This PR adds the end point to delete messages. I've tested this both in normal and in the json-rpc modes.

This closes #558

@bbernhard
Copy link
Owner

bbernhard commented Sep 3, 2025

Many thanks for the contribution!

I quickly scrolled through your PR and it looks good so far. I'll have a more detailed look on the weekend, when I have a bit more time :)

Timestamp int64 `json:"target-timestamp"`
}
request := Request{}
if !isGroup {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and sorry for the late reply!

In general it looks really good, the only small suggestion I'd have is:

Instead of checking with strings.HasPrefix whether it is a group, please use the newly introduced function getRecipientType for that. The big advantage of that one is, that it not only checks if it is a phone number or a group, but also if it is a username.

Copy link
Contributor Author

@Era-Dorta Era-Dorta Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. I've fixed it in de2cb04.

I checked that it still works both with usernames and with group ids.

Is there anything that I need to do to get the CI to pass? It looks like an error unrelated to any of the code changes that I've done.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the CI failures are because the CI pipeline isn't properly configured to handle pull requests. Need to have a look at that one at some point. But for now, I'll just merge the changes.

Thanks!

@bbernhard bbernhard merged commit 3c2a8a2 into bbernhard:master Sep 10, 2025
1 of 2 checks passed
@Era-Dorta Era-Dorta deleted the remote-delete branch September 10, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remoteDelete
2 participants