This repository has been archived by the owner on Mar 8, 2020. It is now read-only.
[native driver] Maintainability improvements #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
juanjux
commented
Nov 16, 2017
juanjux
commented
- Removed old cruft.
- AstImprover: Use light classes for tokens and positions instead of the native tokenizer tuples.
- AstImprover: Remove dependency from the "six" module since it'll only be executed under Python 3.
- AstImprover: Add static typing to the module (it was the only one missing it because it was inherited from pydetector).
- AstImprover: Fixed a couple conversion/reinterpretation bugs found thanks to the static typing.
Signed-off-by: Juanjo Alvarez <juanjo@sourced.tech>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.