Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Upgrade to make it compatible with SDK v1.1 #58

Merged
merged 5 commits into from
Oct 4, 2017
Merged

api: Upgrade to make it compatible with SDK v1.1 #58

merged 5 commits into from
Oct 4, 2017

Conversation

abeaumont
Copy link
Contributor

Signed-off-by: Alfredo Beaumont alfredo.beaumont@gmail.com

This update is required to make it compatible with SDK v1.1.
The server should be running at least v1.1.1 to work with this change and new drivers.

Signed-off-by: Alfredo Beaumont <alfredo.beaumont@gmail.com>
Copy link
Member

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis failed. Test do not pass.
It will be needed to update the bidata stuff as well;

@dpordomingo
Copy link
Member

dpordomingo commented Oct 4, 2017

I'm testing and fixing it locally.

@abeaumont
Copy link
Contributor Author

@dpordomingo it fails in a react test.... I fail to see how it relates to this PR, any hint?

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
@abeaumont
Copy link
Contributor Author

Oh, I did see it incorrectly. I can fix it.

@dpordomingo
Copy link
Member

@dpordomingo
Copy link
Member

But I'm still trying to run it locally.
Did you managed to get it running?

@abeaumont
Copy link
Contributor Author

@dpordomingo ok, great!
Yes, I managed to get it working. You need an uptodate version of the server to make it work.
Note that the server has been renamed to bblfshd now, maybe that's causing the problem?
If you're using docker instead, make sure that you're working with the last version.

abeaumont and others added 2 commits October 4, 2017 14:45
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
Copy link
Member

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is needed the bindata stuff.
It was done by https://github.com/abeaumont/dashboard/pull/2

Update bindata for sdk 1.1 upgrade
Copy link
Member

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for realizing about the changes needed by the sdk 1.1 upgrade!
(and for providing me support about how to locally upgrade it)

@dpordomingo dpordomingo merged commit 846edb6 into bblfsh:master Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants