Skip to content

Catch UnknownJSTypeError for Node and increase timeout for Chrome workflow. #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Catch UnknownJSTypeError for Node and increase timeout for Chrome workflow. #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf64111
fix: catch UnknownJSTypeError for node and chrome platform.
elliotwutingfeng Sep 30, 2025
c524383
fix: Increase timeout for chrome workflow.
elliotwutingfeng Oct 2, 2025
a7e2e7e
fix: Handle errors more specifically.
elliotwutingfeng Oct 2, 2025
55f0422
fix: rethrow unknown exception.
elliotwutingfeng Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/chrome.workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ jobs:
run: dart pub get

- name: Test chrome
run: dart test -j 1 -p chrome
run: dart test --timeout 2x -j 1 -p chrome
13 changes: 11 additions & 2 deletions lib/src/platform_check/web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,19 @@ class PlatformWeb extends Platform {
static bool useBuiltInRng = false;

PlatformWeb() {
useBuiltInRng = false;
try {
Random.secure();
useBuiltInRng = true;
} on UnsupportedError {
useBuiltInRng = false;
// Random.secure() normally throws this error if
// no cryptographically secure random number source is available.
} catch (e) {
// For Node.js with dart2js compiler, the UnknownJsTypeError error is expected.
// This error is internal to 'dart:_js_helper' so we need to inspect the runtimeType.
if (!(e.runtimeType.toString() == 'UnknownJsTypeError')) {
rethrow;
}
}
}

Expand Down Expand Up @@ -48,7 +56,8 @@ class _JsBuiltInEntropySource implements EntropySource {
@override
Uint8List getBytes(int len) {
return Uint8List.fromList(
List<int>.generate(len, (i) => _src.nextInt(256)));
List<int>.generate(len, (i) => _src.nextInt(256)),
);
}
}

Expand Down