Skip to content

Conversation

cyrilbravo
Copy link
Collaborator

@cyrilbravo cyrilbravo commented Feb 13, 2025

Please check if the PR fulfills these requirements:

  • After these changes, the app was run and still works as expected
  • Tests for these changes were added (if applicable)
  • npm audit was checked, applicable vulnerabilities were updated
  • npm run build passes
  • npm run storybook still works
  • npm run lint has no unexpected errors
  • All existing unit tests were run and still pass

Please specify the type of change this PR introduces (Bug fix, feature addition, content update, chore, etc.):

Additional Notes:

@cyrilbravo cyrilbravo changed the base branch from main to vite-migration February 13, 2025 19:33
Copy link
Collaborator

@skylermcnamee-hibc skylermcnamee-hibc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@cyrilbravo cyrilbravo merged commit b791bf7 into vite-migration Feb 13, 2025
4 checks passed
@cyrilbravo cyrilbravo deleted the acc-fix-v3 branch February 13, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants