fix: frontend spa routing #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds SPA routing support to the CloudFront distribution by mapping 403 errors to a fallback path when using S3 origins.
- Introduces a dynamic
custom_error_responseblock to map 403 responses to the root path fordistribution_type = "s3".
| content { | ||
| error_code = 403 | ||
| response_code = 200 | ||
| response_page_path = "/" |
There was a problem hiding this comment.
The response_page_path should point to your SPA entry file (e.g., /index.html) instead of just / to ensure CloudFront serves the correct object.
Suggested change
| response_page_path = "/" | |
| response_page_path = "/index.html" |
Copilot uses AI. Check for mistakes.
| dynamic "custom_error_response" { | ||
| for_each = var.distribution_type == "s3" ? [1] : [] | ||
| content { | ||
| error_code = 403 |
There was a problem hiding this comment.
[nitpick] Consider also handling 404 errors by adding a second custom_error_response block mapping 404 to 200, which is a common practice for SPAs to catch missing routes.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.