Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed mismatch between oauth flow names and sequences #22

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

elf-pavlik
Copy link
Contributor

It appears that sequence diagram had mismatch between oauth flow names and sequences. I only corrected them in diagram's source and before merging you may want to add commit to this PR with updated png rendering.

Signed-off-by: elf Pavlik <elf-pavlik@hackers4peace.net>
@swcurran
Copy link
Contributor

@tplooker - can you please confirm this change? I don't know enough :-). I'm happy to generate the image and replace it in the text.

@elf-pavlik - thanks for the update.

@tplooker
Copy link
Contributor

@swcurran @elf-pavlik, yes this is correct thanks for the change!

Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by @tplooker and deemed correct.

@swcurran swcurran merged commit 4884e12 into bcgov:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants