Clean up resources post PR closure WPS #138 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
DerekRoberts,
Kyubinhan,
Sybrand and
andrea-williams
Sybrand
added a commit
that referenced
this pull request
Jun 4, 2020
* Initial commit * Load default issue templates for bug and feature * Jenkins deployment (#4) * Initial commit for bcdk:jenkins * config update * Pipeline adjustment * Issue Templates + Task request * Update issue templates * Update issue templates * Update issue templates * Update issue templates * Apache License (#47) * README template (#48) * Added a glossary section to the README.md * Removed duplicate glossary entry * Added BUI/DC to glossary * Moved to Wiki * Modified glossary entry * Removed [] * Update issue templates * Update issue templates * Update issue templates added Epic Issue type * Contributing.md (#71) * Code of Conduct from https://www.contributor-covenant.org/ * Code of Conduct contact upgraded to Jake * CONDUCT.md, not CONTRIBUTING.md * Pipeline (#72) * Initial pipeline commit * Post @bcgov/generator-bcdk:jenkins generator * Base MDs (#74) * Cut down README.md filler * Cleaned up README.md and added Contributing * First job (#73) * Add missing compliance audit file (#1) * Add compliance audit file * Updating compliance audit file * Very basic build (#81) * Very basic build * Copy and paste quick run * Excluded .vscode in .gitignore * Cleaned up temp build config * Cleaned up temp deployment config * Jenkins no longer hard coding commands * Cut down bc and dc * Renamed and moved demo templates * Removed VERSION from bc * Removed var * Build now using script * Script now runs from any path * Simplified build script * Deploy script * Cleaned up script output * Jenkinsfile deploying with script * oc_build.sh cleaned up, defaults to dry run * oc_build.sh - verify oc login * Improved oc_build.sh output * Improved oc_build.sh output further * oc_build.sh overhauled to use commented help in script * oc_deploy.sh given same treatment as oc_build.sh * Jenkinsfile now full of stubs * Auto-formatter * Move and remove stale files (#136) * Shared Scripts and Subtree (#137) * Copied scripts from wps-web * Shuffle files, folders and sourcing for subtree * envars pulling NAME from git, have overrides, using BC/DC paths relative to subtree * Script simplification and variable revision * Updated git hub event script with a function to call clean up job when a PR is closed (#139) * Use oc start-build after applying the template (#159) * Use oc start-build after applying the template and remove for loop for following the building process * Cancel non complete build and start new build using oc cancel-build & start-build * Add ConfigMaps to Cleanup and Remove Stale Files (#157) * Include configs maps in cleanup * No longer need .jenkins/ * Pointed formatter at CONDUCT.md * Subtree update (#162) * Simple subtree update script * oc_cleanup.sh typo (#163) * Script changes moving from bash to sh for Coco OC Runner (#180) * Script changes for explicit build and deploy without using any internal triggers (#200) * Remove cancel-build command in oc_build.sh * Use oc rollout to deploy apps in oc_deploy.sh * Added a new fire weather page and keycloak libraries for enabling IDIR based authentication * Removed unnecessary imports * Using hooks to manage state and rendering of components * Added config to enable authentication for accessing fire weather page * Removed unnecessary space * Updated readme with extra step * Updated gitignore * Updated readme and added keycloak example file * Added react testing lib to prod dependencies to resolve the issue * Enhancement to menu items * Updated fire weather page to use keycloak js file on the fly * Added authentication state to redux store rather than to local state * Updated keykloak client name * Added a test for testing authentication slice * Updated template parameter name * Updated package lock * Updated package lock * Updated package and package-lock * Added reset function to reset the authentication state * Added an env var to update keycloak auth url when promoting to prod * Added keycloak dev URL to env vars * Added dev url as a default value * Updated test description * 1. Removed app thunk 2. Using env variables instead of config map 3. Loading keycloak.js independently from react component * Removed unused import * Removed unused volume mount * Updated gitignore and readme * Using global config map to fetch env vars * Remove scripts dir, to replace * Promote to distinct PROD imagestream, retage explicitly * Removed common tag from now separate imagestreams * Updated config map name * Renamed variable name * Bug - use SUFFIX, not latest for tags * Bug - use SUFFIX, not latest for tags * Replacing script subtree Co-authored-by: Derek Roberts <4391600+DerekRoberts@users.noreply.github.com> Co-authored-by: Sybrand Strauss <sybrand.strauss@gov.bc.ca> Co-authored-by: jakemorr <60238848+jakemorr@users.noreply.github.com> Co-authored-by: repo-mountie[bot] <44246292+repo-mountie[bot]@users.noreply.github.com> Co-authored-by: Kyubin Han <kyubinhan11@gmail.com> Co-authored-by: Derek Roberts <derek.roberts@gmail.com>
Sybrand
added a commit
that referenced
this pull request
Jun 4, 2020
* Initial commit * Load default issue templates for bug and feature * Jenkins deployment (#4) * Initial commit for bcdk:jenkins * config update * Pipeline adjustment * Issue Templates + Task request * Update issue templates * Update issue templates * Update issue templates * Update issue templates * Apache License (#47) * README template (#48) * Added a glossary section to the README.md * Removed duplicate glossary entry * Added BUI/DC to glossary * Moved to Wiki * Modified glossary entry * Removed [] * Update issue templates * Update issue templates * Update issue templates added Epic Issue type * Contributing.md (#71) * Code of Conduct from https://www.contributor-covenant.org/ * Code of Conduct contact upgraded to Jake * CONDUCT.md, not CONTRIBUTING.md * Pipeline (#72) * Initial pipeline commit * Post @bcgov/generator-bcdk:jenkins generator * Base MDs (#74) * Cut down README.md filler * Cleaned up README.md and added Contributing * First job (#73) * Add missing compliance audit file (#1) * Add compliance audit file * Updating compliance audit file * Very basic build (#81) * Very basic build * Copy and paste quick run * Excluded .vscode in .gitignore * Cleaned up temp build config * Cleaned up temp deployment config * Jenkins no longer hard coding commands * Cut down bc and dc * Renamed and moved demo templates * Removed VERSION from bc * Removed var * Build now using script * Script now runs from any path * Simplified build script * Deploy script * Cleaned up script output * Jenkinsfile deploying with script * oc_build.sh cleaned up, defaults to dry run * oc_build.sh - verify oc login * Improved oc_build.sh output * Improved oc_build.sh output further * oc_build.sh overhauled to use commented help in script * oc_deploy.sh given same treatment as oc_build.sh * Jenkinsfile now full of stubs * Auto-formatter * Move and remove stale files (#136) * Shared Scripts and Subtree (#137) * Copied scripts from wps-web * Shuffle files, folders and sourcing for subtree * envars pulling NAME from git, have overrides, using BC/DC paths relative to subtree * Script simplification and variable revision * Updated git hub event script with a function to call clean up job when a PR is closed (#139) * Use oc start-build after applying the template (#159) * Use oc start-build after applying the template and remove for loop for following the building process * Cancel non complete build and start new build using oc cancel-build & start-build * Add ConfigMaps to Cleanup and Remove Stale Files (#157) * Include configs maps in cleanup * No longer need .jenkins/ * Pointed formatter at CONDUCT.md * Subtree update (#162) * Simple subtree update script * oc_cleanup.sh typo (#163) * Script changes moving from bash to sh for Coco OC Runner (#180) * Script changes for explicit build and deploy without using any internal triggers (#200) * Remove cancel-build command in oc_build.sh * Use oc rollout to deploy apps in oc_deploy.sh * Added a new fire weather page and keycloak libraries for enabling IDIR based authentication * Removed unnecessary imports * Using hooks to manage state and rendering of components * Added config to enable authentication for accessing fire weather page * Removed unnecessary space * Updated readme with extra step * Updated gitignore * Updated readme and added keycloak example file * Added react testing lib to prod dependencies to resolve the issue * Enhancement to menu items * Updated fire weather page to use keycloak js file on the fly * Added authentication state to redux store rather than to local state * Updated keykloak client name * Added a test for testing authentication slice * Updated template parameter name * Updated package lock * Updated package lock * Updated package and package-lock * Added reset function to reset the authentication state * Added an env var to update keycloak auth url when promoting to prod * Added keycloak dev URL to env vars * Added dev url as a default value * Updated test description * 1. Removed app thunk 2. Using env variables instead of config map 3. Loading keycloak.js independently from react component * Removed unused import * Removed unused volume mount * Updated gitignore and readme * Using global config map to fetch env vars * Remove scripts dir, to replace * Promote to distinct PROD imagestream, retage explicitly * Removed common tag from now separate imagestreams * Updated config map name * Renamed variable name * Bug - use SUFFIX, not latest for tags * Bug - use SUFFIX, not latest for tags * Replacing script subtree Co-authored-by: Derek Roberts <4391600+DerekRoberts@users.noreply.github.com> Co-authored-by: Sybrand Strauss <sybrand.strauss@gov.bc.ca> Co-authored-by: jakemorr <60238848+jakemorr@users.noreply.github.com> Co-authored-by: repo-mountie[bot] <44246292+repo-mountie[bot]@users.noreply.github.com> Co-authored-by: Kyubin Han <kyubinhan11@gmail.com> Co-authored-by: Derek Roberts <derek.roberts@gmail.com>
vanislekahuna
pushed a commit
to vanislekahuna/wps
that referenced
this pull request
Sep 19, 2024
…n a PR is closed (bcgov#139)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new job under _SYS in Jenkins that is triggered by PR closure for removing resources.