Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GERO-318 - all IPR-A evidence equivalents are considered 'approvedTherapy' #107

Merged
merged 5 commits into from
Apr 13, 2023

Conversation

dustinbleile
Copy link
Contributor

ipr/ipr.py Outdated
@@ -144,6 +144,8 @@ def convert_statements_to_alterations(

approved = convert_to_rid_set(get_approved_evidence_levels(graphkb_conn))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we get the approved evidence level directly by the matching IPR level (with get_evidencelevel_mapping()) instead of

def get_approved_evidence_levels(graphkb_conn: GraphKBConnection) -> List[Record]:
filters = []
for source, names in APPROVED_EVIDENCE_LEVELS.items():
filters.append(
{
'AND': [
{'source': {'target': 'Source', 'filters': {'name': source}}},
{'name': names, 'operator': 'IN'},
]
}
)
return graphkb_conn.query({'target': 'EvidenceLevel', 'filters': {'OR': filters}})

and then
APPROVED_EVIDENCE_LEVELS = {
# sourceIds of levels by source name
'oncokb': ['1', 'r1'],
'profyle': ['t1'],
'cancer genome interpreter': [
'cpic guidelines',
'european leukemianet guidelines',
'fda guidelines',
'nccn guidelines',
'nccn/cap guidelines',
],
}
?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think I asked pretty much the same thing just now on GERO-318

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with these suggested changes based on clinical.

@dustinbleile dustinbleile merged commit ca1ee28 into develop Apr 13, 2023
@dustinbleile dustinbleile deleted the GERO-318_all_IPR-A_as_Approved_Therapies branch May 19, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants