Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3.13.0 #145

Merged
merged 7 commits into from
Feb 29, 2024
Merged

Release v3.13.0 #145

merged 7 commits into from
Feb 29, 2024

Conversation

elewis2
Copy link
Collaborator

@elewis2 elewis2 commented Feb 16, 2024

release notes v3.12.3:

Improvements:

  • DEVSU-2216: add 'recruitment_status' to kb_data in KbMatch results where statement subject is a clinical trial

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.34%. Comparing base (6d8271a) to head (6f8631c).
Report is 258 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #145       +/-   ##
===========================================
- Coverage   91.90%   53.34%   -38.56%     
===========================================
  Files          10       10               
  Lines        1013     1269      +256     
===========================================
- Hits          931      677      -254     
- Misses         82      592      +510     
Flag Coverage Δ
unittests 53.34% <100.00%> (-38.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elewis2 elewis2 requested a review from calchoo February 26, 2024 18:00
@@ -18,7 +18,7 @@ known_standard_library = requests

[metadata]
name = ipr
version = 3.12.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an entirely new feature, right?

I think then, the version would usually be increased to v3.13.0, but that is minor.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is but it is so trivial. You're probably right though, I'll update that.

@elewis2 elewis2 changed the title Release v3.12.3 Release v3.13.0 Feb 29, 2024
@elewis2 elewis2 merged commit 4d75e9e into master Feb 29, 2024
7 checks passed
@elewis2 elewis2 deleted the release-v3.12.3 branch February 29, 2024 00:43
@mathieulemieux
Copy link
Member

Nothing to complain about but just pointing out that changes happening after review don't seem to dismiss approval.

@creisle
Copy link
Member

creisle commented Feb 29, 2024

Nothing to complain about but just pointing out that changes happening after review don't seem to dismiss approval.

fixed! not sure how that setting got turned off (maybe github updated something? @elewis2 you may want to double check the other repos to make sure its not space-wide problem)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants