Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more clear status marks #236

Merged
merged 3 commits into from
Jun 11, 2021
Merged

Use more clear status marks #236

merged 3 commits into from
Jun 11, 2021

Conversation

stokito
Copy link
Contributor

@stokito stokito commented Nov 23, 2020

Instead of bullet for status and plus for health we can use more known symbols:

screenshot gnome terminal

I chose this symbols because they are part of Unicode 1993 and should be supported by all fonts.

  • ☼ sun for healthy
  • ⚠ warning for unhealthy
  • ◌ dotet circle for starting

Please check how they looks in iTerm on OSX. Unfortunately they wont be shown correctly on Putty from windows because it uses Currier New font but previous statuses wasn't shown ether.

s.health and s.status are always have only one element with a single char length
@mtklr
Copy link

mtklr commented Feb 28, 2021

Thanks, I really like this change and hope it gets merged eventually - red-green color blindness makes it really difficult to differentiate the default symbols. (It would also be nice if the symbols were user-configurable.:)

@stokito
Copy link
Contributor Author

stokito commented Feb 28, 2021

I don’t think it worth to make configurable but agree that green/red colors doesn’t work for color blind peoples. But this may be changed by theme. Maybe even current reversed theme will be better for color blind peoples.
The most I concerned is about symbols to be clear and how they look in terminal fonts.
Personally now I don’t feel right about using the dotted circle but as far I remember all other symbols looked much worse. I hope that containers will start so fast so users not even notice the circle.

@bcicen bcicen added this to the v0.7.7 milestone Jun 11, 2021
@bcicen bcicen merged commit 29f9abf into bcicen:master Jun 11, 2021
@stokito stokito deleted the status_unicode branch June 11, 2021 05:05
@bcicen bcicen mentioned this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants