Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read.pcadapt(pool.data, type = "pool") throws error #10

Closed
jkreinz opened this issue Feb 21, 2018 · 14 comments
Closed

read.pcadapt(pool.data, type = "pool") throws error #10

jkreinz opened this issue Feb 21, 2018 · 14 comments

Comments

@jkreinz
Copy link

jkreinz commented Feb 21, 2018

I've formatted my poolseq data where rows are pops and columns are snp markers. I keep getting the following error when using read.pcadapt, which occurs even on the example data:

filename <- read.pcadapt(pool.data, type = "pool")
Error in read.pcadapt(pool.data, type = "pool") :
Argument input.filename has to be a character string.

@privefl
Copy link
Member

privefl commented Feb 22, 2018

Hello @jkreinz,

We are currently working on a new version of pcadapt (4.0.0).
You can get the development version with devtools::install_github("privefl/pcadapt").
This is still a work in progress but it should work for poolseq data using

pool_data <- read.pcadapt(pool.data, type = "pool")
pcadapt(pool_data)

You can find the documentation (also in progress) there.

@jkreinz
Copy link
Author

jkreinz commented Feb 22, 2018 via email

@privefl
Copy link
Member

privefl commented Feb 23, 2018

Hum, on several platforms, are you sure? It is a well-known Mac issue with RcppArmadillo.
Yet, I don't know why RcppArmadillo is still a dependency in the new version..

Please see this blog post.

@mblumuga
Copy link
Member

mblumuga commented Feb 23, 2018

The blog post mentioned by @privefl should provide solutions to your installation issue. This issue can arise because pcadapt 4.0 depends on Rcpp.

@privefl
Copy link
Member

privefl commented Feb 23, 2018

RcppArmadillo*

@jkreinz
Copy link
Author

jkreinz commented Mar 7, 2018 via email

@mblumuga
Copy link
Member

mblumuga commented Mar 8, 2018

Can you try the new version of pcadapt which is available on https://github.com/privefl/pcadapt/.

Main changes concern Pooled-Seq data. Score plot, scree plot, and get.pc functions available for Pooled-seq data.

Will be glad to read your remarks if you have any.

@jkreinz
Copy link
Author

jkreinz commented Mar 8, 2018 via email

@mblumuga
Copy link
Member

mblumuga commented Mar 8, 2018

With 3 pools, it works fine. However, it is true that there is a bug with 2 pools. We are working on it right now.

@mblumuga
Copy link
Member

mblumuga commented Mar 8, 2018

@jkreinz we fix the pbm with 2 pools. Can you try the new version please available at https://github.com/privefl/pcadapt/

@jkreinz
Copy link
Author

jkreinz commented Mar 8, 2018 via email

@mblumuga
Copy link
Member

mblumuga commented Mar 9, 2018

How many pools do you have? Would it be possible for you to send me part of your data (1 contig, 1 chromosome) so that I can replicate your bug.

@privefl
Copy link
Member

privefl commented Mar 9, 2018

You can reproduce the bug with

pool.file <- system.file("extdata/pool3pops", package = "pcadapt")

pool.data <- as.matrix(read.table(pool.file))[1:2, ]
pool.data[, 1] <- c(0, 0.05)

pool.data <- read.pcadapt(pool.data, type = "pool")
pcadapt(pool.data)

@mblumuga
Copy link
Member

mblumuga commented Mar 9, 2018

@jkreinz we fix the pbm you mentionned. Can you try the new version available at https://github.com/privefl/pcadapt/

@privefl privefl closed this as completed Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants