refactor tests (rebased)

[livingrockrises]

No description provided.

[github-actions]

🤖 Slither Analysis Report 🔎

Slither report

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🔴 - name-reused (1 results) (High)
🟡 - unused-return (3 results) (Medium)
🔵 - shadowing-local (1 results) (Low)
🔵 - missing-zero-check (1 results) (Low)
🔵 - reentrancy-events (2 results) (Low)
ℹ️ - assembly (9 results) (Informational)
ℹ️ - dead-code (6 results) (Informational)
ℹ️ - low-level-calls (1 results) (Informational)
ℹ️ - naming-convention (1 results) (Informational)
ℹ️ - redundant-statements (1 results) (Informational)

name-reused

🔴 Impact: High
🔴 Confidence: High

• ID-0
  IModuleManager is re-used:
  • IModuleManager
  • IModuleManager

interfaces/base/IHookManager.sol#L8-L11

unused-return

🟡 Impact: Medium
🟡 Confidence: Medium

• ID-1
  SmartAccount.execute(ModeCode,bytes) ignores return value by (callType,execType) = mode.decode()

SmartAccount.sol#L51-L82

• ID-2
  SmartAccount.executeFromExecutor(ModeCode,bytes) ignores return value by (callType,execType) = mode.decode()

SmartAccount.sol#L84-L134

• ID-3
  SmartAccount.supportsExecutionMode(ModeCode) ignores return value by (callType,execType) = mode.decode()

SmartAccount.sol#L184-L204

shadowing-local

🔵 Impact: Low
🔴 Confidence: High

• ID-4
  SmartAccount.validateUserOp(PackedUserOperation,bytes32,uint256).nonce shadows:
  • ERC4337Account.nonce(uint192) (function)

SmartAccount.sol#L37

missing-zero-check

🔵 Impact: Low
🟡 Confidence: Medium

• ID-5
  AccountFactory.constructor(address).implementation lacks a zero-check on :
  - ACCOUNT_IMPLEMENTATION = implementation

factory/AccountFactory.sol#L11

reentrancy-events

🔵 Impact: Low
🟡 Confidence: Medium

• ID-6
  Reentrancy in SmartAccount.uninstallModule(uint256,address,bytes):
  External calls:
  • _uninstallValidator(module,deInitData)
    • IValidator(validator).onUninstall(disableModuleData)
  • _uninstallExecutor(module,deInitData)
    • IExecutor(executor).onUninstall(disableModuleData)
      Event emitted after the call(s):
  • ModuleUninstalled(moduleTypeId,module)

SmartAccount.sol#L163-L174

• ID-7
  Reentrancy in SmartAccount.installModule(uint256,address,bytes):
  External calls:
  • _installValidator(module,initData)
    • IValidator(validator).onInstall(data)
  • _installExecutor(module,initData)
    • IExecutor(executor).onInstall(data)
      Event emitted after the call(s):
  • ModuleInstalled(moduleTypeId,module)

SmartAccount.sol#L146-L161

assembly

ℹ️ Impact: Informational
🔴 Confidence: High

• ID-8
  ModeLib.decode(ModeCode) uses assembly
  • INLINE ASM

lib/ModeLib.sol#L87-L98

• ID-9
  Storage._getAccountStorage() uses assembly
  • INLINE ASM

base/Storage.sol#L18-L22

• ID-10
  SmartAccount.validateUserOp(PackedUserOperation,bytes32,uint256) uses assembly
  • INLINE ASM

SmartAccount.sol#L25-L48

• ID-11
  AccountExecution._execute(address,uint256,bytes) uses assembly
  • INLINE ASM

base/AccountExecution.sol#L50-L73

• ID-12
  AccountExecution._executeDelegatecall(address,bytes) uses assembly
  • INLINE ASM

base/AccountExecution.sol#L97-L113

• ID-13
  ModeLib.getCallType(ModeCode) uses assembly
  • INLINE ASM

lib/ModeLib.sol#L122-L126

• ID-14
  ExecLib.decodeBatch(bytes) uses assembly
  • INLINE ASM

lib/ExecLib.sol#L11-L27

• ID-15
  AccountExecution._tryExecute(address,uint256,bytes) uses assembly
  • INLINE ASM

base/AccountExecution.sol#L75-L94

• ID-16
  AccountExecution._tryExecuteDelegatecall(address,bytes) uses assembly
  • INLINE ASM

base/AccountExecution.sol#L116-L134

dead-code

ℹ️ Impact: Informational
🟡 Confidence: Medium

• ID-17
  ModuleManager._isAlreadyInitialized() is never used and should be removed

base/ModuleManager.sol#L128-L132

• ID-18
  _eqModeSelector(ModeSelector,ModeSelector) is never used and should be removed

lib/ModeLib.sol#L141-L143

• ID-19
  AccountExecution._executeDelegatecall(address,bytes) is never used and should be removed

base/AccountExecution.sol#L97-L113

• ID-20
  AccountExecution._tryExecute(Execution[]) is never used and should be removed

base/AccountExecution.sol#L38-L48

• ID-21
  AccountExecution._tryExecute(address,uint256,bytes) is never used and should be removed

base/AccountExecution.sol#L75-L94

• ID-22
  AccountExecution._tryExecuteDelegatecall(address,bytes) is never used and should be removed

base/AccountExecution.sol#L116-L134

low-level-calls

ℹ️ Impact: Informational
🔴 Confidence: High

• ID-23
  🔵 Low level call in SmartAccount.executeUserOp(PackedUserOperation,bytes32):
  • (success) = address(this).delegatecall(callData)

SmartAccount.sol#L137-L144

naming-convention

ℹ️ Impact: Informational
🔴 Confidence: High

• ID-24
  Variable AccountFactory.ACCOUNT_IMPLEMENTATION is not in mixedCase

factory/AccountFactory.sol#L9

redundant-statements

ℹ️ Impact: Informational
🔴 Confidence: High

• ID-25
  Redundant expression "additionalContext" inSmartAccount

SmartAccount.sol#L211

This comment was automatically generated by the GitHub Actions workflow.