fix: Fix usage of excludeAfterRemap not to set the coverage always to 100 #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the issue for me. @bcoe is there any chance to get this fix merged? Or is there another workaround? |
… 100 Do not use the `excludePath` callback. Remove the excluded sources at the end, after all coverage parts have been merged. This might be a problem in `v8-to-istanbul`, because `istanbul-lib-coverage` doesn't offer a method to filter the coverage data at the end. Attempts to fix bcoe#462
prantlf
force-pushed
the
exclude-after-remap-always-100
branch
from
9113449
to
1aab44c
Compare
|
Any chance you could add a test? |
|
Unfortunately, I cannot use c8 because of the problem. Is there a chance to merge this pull request anyway? |
|
@timokoessler, @tbo, I would need to see a failing test to be able to land this (I would be very appreciative of a PR that just adds the failing test 👏 @prantlf has provided a repository with a reproduction, so I can use this as a starting point. I'll do my best to start putting a bit more work into this library again, and it seems like this bug should be high up the list of things to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use the
excludePathcallback. Remove the excluded sources at the end, after all coverage parts have been merged. This might be a problem inv8-to-istanbul, becauseistanbul-lib-coveragedoesn't offer a method to filter the coverage data at the end.Attempts to fix #462
Checklist
npm test, tests passingnpm run test:snap(to update the snapshot)