Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: force exit the process when completed #82

Merged
merged 3 commits into from
Apr 30, 2019
Merged

feat: force exit the process when completed #82

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bad7819
feat: force exit the process when completed
popomore Apr 28, 2019
f411180
f
popomore Apr 28, 2019
931a5ac
f
popomore Apr 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bin/c8.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@ let argv = buildYargs().parse(instrumenterArgs)
}

process.env.NODE_V8_COVERAGE = argv.tempDirectory
foreground(hideInstrumenterArgs(argv), () => {
foreground(hideInstrumenterArgs(argv), done => {
outputReport(argv)
done()
Copy link
Contributor

@shinnn shinnn Apr 29, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed. Even if no callback function is provided, foreground-child itself will do what you do here. https://github.com/tapjs/foreground-child/blob/v1.5.6/index.js#L22-L24

Copy link
Contributor Author

@popomore popomore Apr 29, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But c8 has passed ths cb argument without done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed.

})
}
})()