Minor RPC Test updates

[nodech]

Move wallet rpc tests to its own file.
Clean up some test cases.
There is only minor logic clean up done in this PR.

Upcoming PRs will try to make each test case as independent as possible as well.

[braydonf]

Noticed that as well, very few node rpc tests, as rpc-test is actually mostly wallet tests, good to have that organized.

This will conflict with #605 and it will need to be rebased yet again (currently needs rebase).

[pinheadmz]

LGTM, tests pass locally. Code coverage is the same as master PLUS the bonus coverage of wallet RPC getwalletinfo 👍

[tynes]

I started test/wallet-rpc-test.js so that each RPC method could have its own describe, we probably want to be sure to keep things in a similar style if we are adding to that file

[nodech]

@tynes That's the plan, when I add more test cases to each of the calls it will become describe and more isolated (so you can run tests separately). This is kinda first step to that.

[nodech]

@braydonf yeah, that's unfortunate. That's one of the reasons I did this early to other rpc PRs so we can avoid rapid rebases on other pending PRs. My other PR #802 will need rebase as well.

[braydonf]

There is a chance this isn't restored if any of the below fail within this test, it'll probably be preferable to quickly generate more than 100 blocks, at the start of the tests and avoid modifying globals, or at-least do so carefully.

[braydonf]

May be another follow-up that is necessary, there may be other such cases.

[nodech]

yeah, this can happen if before fails and can affect other test cases.

Ideally consensus should be accepted as parameters in places where it's necessary instead of being used as globals. That would make testing much easier and more flexible.

Generating 100 blocks is not too much to ask but slows downs generation quite a lot, in case we have many separate test cases it may become burden. We could have "mock" chain that already has 100 blocks in one way or another backed up in test/data

[braydonf]

Generating 200 blocks takes around 400-180ms, as from some other tests.

[braydonf]

If it's done a lot, it could add up, but generally there can be setup scripts that build out a chain, and many tests that run against it.

[nodech]

@braydonf okay, pushed your proposed changes to the walletrpc. thanks

[braydonf]

In case anyone runs into unusually slow CI tests again (as experienced here), it's resolved by specifiying the workerSize (background details at #777). It's related to nyc and there being far too many workers by default as the CI environment has many cores.