Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove -p option from CLI #209

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Remove -p option from CLI #209

merged 1 commit into from
Sep 9, 2022

Conversation

bcollazo
Copy link
Owner

@bcollazo bcollazo commented Sep 9, 2022 •
edited
Loading

See #207. The idea is to avoid users accidentally using -players=....

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3023326948

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.519%
Totals Coverage Status
Change from base Build 2939937839: 0.0%
Covered Lines: 1279
Relevant Lines: 1339
💛 - Coveralls

@bcollazo bcollazo temporarily deployed to catanatron-feature-remo-y7iob5 September 9, 2022 14:58 Inactive
@bcollazo bcollazo merged commit e7129c6 into master Sep 9, 2022
@bcollazo bcollazo deleted the feature/remove-p-option branch September 9, 2022 15:17
@bcollazo bcollazo mentioned this pull request Jan 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcollazo @coveralls