Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs and miscellaneous #46

Merged
merged 6 commits into from
Oct 31, 2020
Merged

Fix bugs and miscellaneous #46

merged 6 commits into from
Oct 31, 2020

Conversation

bcollazo
Copy link
Owner

@bcollazo bcollazo commented Oct 31, 2020 •
edited
Loading

Fixes #44 and #43

@coveralls
Copy link

coveralls commented Oct 31, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 339385984

  • 27 of 30 (90.0%) changed or added relevant lines in 4 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.5%) to 93.021%
Changes Missing Coverage Covered Lines Changed/Added Lines %
catanatron/game.py 6 9 66.67%
Files with Coverage Reduction New Missed Lines %
catanatron/json.py 1 95.35%
catanatron/game.py 3 85.82%
catanatron/models/board.py 3 96.1%
Totals Coverage Status
Change from base Build 328187162: -0.5%
Covered Lines: 973
Relevant Lines: 1046
💛 - Coveralls

@bcollazo bcollazo merged commit 9170521 into master Oct 31, 2020
@bcollazo bcollazo deleted the fix/bugs branch October 31, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyError: when computing longest road
2 participants
@bcollazo @coveralls