My modifications for future version 0.3 #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add modify command - Add delete command - Document class and method
- Add a check_manager method. - Add renaming of a manager_name. - Replace " by ' for PEP8 reason (not mixing them).
- Add a getinfo command (not working yet)
- Better handle connection errors. - Better handle login errors. - Improve exception process. - Update examples. - Make examples compatible with new configuration file. - Show exception handling. - Validate trusted SSL connection. - Various PEP8 corrections.
- An empty login allow to connect to the DMTF refish mockup by setting simulator=True, verify_cert=False, enforceSSL=False.
- Try to factorise initialize_logger into redfish.config. - Remove global logger declaration to avoid potential side effects. - Add new logging.debug instead of print and try to cleanup. - Allow logger.setlevel to be more flexible by configuring console and file level of log. - Prepare client to allow optional debug parameter with loglevel selection.
- These messages make polution to the console using the client. The idea is to remove them in low level logging. However these message are interesting so keep them for debugging purpose.
- Add first exception handling to get_manager_info. Maybe I will have to factorise that later...
- Allow client to choose optional debug parameter with loglevel from command line.
- Change ManagersCollection to not report a list by a dict.
The managers_dict will contain index --> manager object, index is the
redfish index as reported inside url
- Notice that Proliant firmware now uses EthernetInterfaces as specified
by Redfish
- Bug to be reported :
/redfish/v1/Managers/1/EthernetInterfaces/1 returns invalid content (not json)
- Revert some changes on " to ' as it can break json data. Example :
return self.set_parameter_json('{"Boot": {"BootSourceOverrideTarget":
"'+target+'"},{"BootSourceOverrideEnabled" : "'+enabled+'"}}')
- Update type.py with new manager functions and manage exceptions. - Retrieve some basic manager data from client getinfo.
- Specify a name for the logger as recommended by the logging documentation. However for strange reason requests logs are not anymore capture in the log file. This needs to be reviewed.
- Change EthernetInterfacesCollection to not report a list but a dict. This change will be the same on *Collection. - Factorise get_name function from Root to Base class as Name parameter seems defined for all kind of Redfish objects. - Report first EthernetInterfaces data in redfish-client as an example --> need to be elaborated
- This is a WIP.
- Add get_mac, get_fqdn, get_ipv4, get_ipv6.
- Add function get_managed_chassis. - Add function get_managed_systems. - Modiy mapping to handle proliant fw 2.40 bugs reporting : - links instead of Links. - href instead of @odata.id. - I'll report this bug to redfish folks. - Various PEP8 cleans.
- Use templating system, so user will be able to customize output. - This could be use later to propose output in various format (html, xml, json). - Undefined EthernetInterfacesCollection in case of failure. So it allows to test definition in the template or elsewhere.
- Fix for empty login or password entry. - Remove pprint because it prints stuff to the console even in no debug mode.
- Remove apache pid file. So it allows to restart the mockup after a brutal shutdown of the container.
bcornec
added a commit
that referenced
this pull request
Jan 18, 2016
My modifications for future version 0.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.