Update oesenc_pi.cpp #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable the isDongleAvailable check for ARM64. ARM64 uses an older version of oeserverd which misses support for USB dongles. This causes OpenCPN to halt since the option used is not available.
Without the arm64 patch the plugin tries to generate an armhf plugin for an arm64 system. This won't work. Better copy the cmake code used in OpenCPN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable the isDongleAvailable check for ARM64.
ARM64 uses an older version of oeserverd which misses support for USB dongles.
This causes OpenCPN to halt since the option used is not available. (quickfix for issue #55 and #56)
2nd PR fixes package build for arm64. Without patch something like a armhf package with arm64 binaries is built. Such a package does not work. (issue #52)