No output in the body when using Django dev server #16
Comments
|
I have the same issue since v0.7 beta, also with a self-hosted healthcheck.io instance. So far, I am back to v0.6 stable. |
|
Yes I read your issue yesterday |
If you read #14, then you saw the simple web server pasted to debug the operation. Can you by any chance run it to see if runitor is sensing the body? Do you have an option to dump the entire HTTP session on the receiver side (the instance that handles requests to healthchecks.openstack.local) I tried to reproduce the issue running a hosted HC instance locally in a container, and then on another machine in the same network, but couldn't reproduce the behavior you and @lakemike report. Maybe we can ping @cuu508 to give us some hot debugging tips. |
|
Looks like I can reproduce it when testing against a development version of Healthchecks running locally ( runitor 0.6.0 sends the Content-Length header but runitor 0.7.0 sends I suspect the Django development server doesn't like "chunked" 0.6.0:
0.7.0:
|
|
Pretty sure it has something to do with the chunked encoding. Command: If I use "Follow TCP stream" in Wireshark, I can see the chunk sizes sent by the client (
And the server complains about "3" – looks like it doesn't recognize it. |
|
Thanks for the helpful pointers @cuu508. No wonder I couldn't reproduce this because local container was behind Caddy and the remote install was behind Nginx. It's a bummer Django's dev server doesn't fully support HTTP RFC but unless I'm overlooking a fact, runitor doesn't need to stream the request either. The decision to do chunked encoding comes from Go's HTTP library (here exactly https://golang.org/src/net/http/transfer.go#L167). I'll run a few sessiosn under debugger to see what underlying change from 0.6.0 to 0.7.0 changed code flow to take |
Yet it returns HTTP 200 as the status while the body mentions and HTTP 400 Bad Request? |
|
Request preparation goes through a type switch at https://golang.org/src/net/http/request.go#L888. With 0.7.0, the ping body is read from a ring buffer to implement tailing with limited resources. Because it doesn't match this limited type switch, library proceeds with assumption of not being able to deduce a header send time content length, resorting to transfer encoding. I have two options: I either introduce a type switch in I'll get back to this later today. |
Go's net/http/request.go cannot deduce the body size if what's
behind io.Reader isn't a *bytes.{Buffer,Reader} or *strings.Reader.
*internal.RingBuffer merely implements the io.Reader interface, with
no way of hinting available data length. This causes requests to use
chunked Transfer-Encoding.
Apparently Django's development server doesn't support chunked
encoding but still returns HTTP 200 while the body says HTTP 400...
To cater to Healthchecks private instances served this way, we do a
type assertion for *internal.RingBuffer, and manually set content
length. This should result a request with a Content-Length header
and no Transfer-Encoding.
Fixes #14 and #16
|
@cuu508 @fabMrc @lakemike can you try with 0.7.1-beta.1 binaries? See the commit above, it's essentially a two line change, explicitly setting the content length to prevent conversion to chunked encoding. I only tested this with tcpdump. I'd appreciate a 👍 or 👎 with Django devel server setup. |
bdd
changed the title
bdd
changed the title
|
0.7.1-beta.1 works here with the Django dev server:
|
|
Fixed it works nice I receive log in email body and it is recorded in healtcheckio |
|
@fabMrc are using Django development server in your setup? If so, please consider switching to gunicorn or uwsgi. From Django docs:
|
|
No I am using uwsgi |
|
This fixed it. Thank you very much! 👍 |
TIL uwsgi doesn't yet automagically support chunked. It supports reading chunked request body using uwsgi-specific API. And there's a |
|
Alright, v0.7.1 is out for the two (maybe three) people in the world, running their instances behind toy servers and want to use runitor ;) |
|
haha nice to be a VIP user ^^ I am using linuxserver/healthckeckio docker image |
When we were handling implicit conversion to chunked encoding due to ring buffer use in #16, we missed one other case client reverts to chunked encoding: empty request body. Since Go 1.8*, the ambiguity of default zero value for `ContentLength` or explicit setting to zero must be handled with explicit passing of `http.NoBody` or `nil` to avoid use of chunked encoding. Pings with empty bodies--i.e. command with no stdout/err continued to result chunked encoding. Start pings were not affected because instead of an empty ring buffer, they always had `nil` passed as their bodies. * https://golang.org/doc/go1.8#net_http
I am trying runitor and I notice log attachment is not working in the last 0.7.0
I succeed in attaching logs with curl command
I have a self provisioned hosted instance of healtcheck.io
is working
but :
does not attach anything
The text was updated successfully, but these errors were encountered: