Allowed real number appear in text like "5.5 days ago" #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philiptzou
force-pushed
the
pull-request-real-timedeltas
branch
from
add4020 to
f8097a5
Compare
|
@bear @idpaterson can you help to review this? Thank you! |
|
+1 looks good to me |
|
This looks great! I wonder if we should allow values between 0 and 1 without a leading zero? For example, .3333 or .5. It looks like the regex will not pick those up: I haven't tested that so there may be conflicts but that's the only suggestion I have - good work! |
|
let's merge this and then iterate on the [non]leading zero issue next pass |
philiptzou
added a commit
that referenced
this pull request
Sep 4, 2015
Allowed real number appear in text like "5.5 days ago"
|
Cool! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #100.