Master #128
Merged
Master #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added back inheritance of object as it is required for python2 support. rtype is added back to reduce risk of overall impact of change.
|
Does that work in your PyCharm? |
|
yep. I can confirm this fixes the issue. |
| @@ -271,6 +271,8 @@ def __init__(self, constants=None, version=VERSION_FLAG_STYLE): | |||
| @param version: Default style version of current Calendar instance. | |||
| Valid value can be 1 (L{VERSION_FLAG_STYLE}) or | |||
| 2 (L{VERSION_CONTEXT_STYLE}). See L{parse()}. | |||
|
|
|||
| @rtype: Calendar | |||
There was a problem hiding this comment.
I think there are 2 tabs but not 8 spaces. Please fix it. And please remove the extra spaces/tabs of line 274.
converted tabs to spaces and added .editorconfig file to prevent this from happening in the future. .editorconfig file are supported by many IDEs including notepad++, Idea, etc...
|
for the record... anyone is allowed to tell me nicely "hey, umm, bear... that's a silly change ;)" thanks for the issue @sbonnick and for the curation @philiptzou |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made changes as discussed in previous pull request: #127