Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of pdt_locales #130

Merged
merged 8 commits into from
Oct 20, 2015
Merged

Refactoring of pdt_locales #130

merged 8 commits into from
Oct 20, 2015

Conversation

philiptzou
Copy link
Collaborator

This is suggest refactoring version for issue #124 which intend to remove the redundant pdtLocale classes and init methods.


locales = ['de_DE', 'en_AU', 'en_US', 'es', 'nl_NL', 'pt_BR', 'ru_RU']
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I struggled between the auto-discovering trick and this for a while. But when I realized that as import this said that "explicit is better than implicit", I thought we should just keep it like this -- simple and stupid -- even it's a bit redundant.

@bear
Copy link
Owner

bear commented Oct 19, 2015

+1 to keeping the locales list very simple and explicit

+1 to this PR

@codecov-io
Copy link

Current coverage is 73.29%

Merging #130 into master will increase coverage by +4.13% as of 2771d36

@@            master    #130   diff @@
======================================
  Files           13      14     +1
  Stmts         1683    1539   -144
  Branches       283     292     +9
  Methods          0       0       
======================================
- Hit           1164    1128    -36
- Partial         92      93     +1
+ Missed         427     318   -109

Review entire Coverage Diff as of 2771d36

Powered by Codecov. Updated on successful CI builds.

@philiptzou
Copy link
Collaborator Author

Just rebased.

bear added a commit that referenced this pull request Oct 20, 2015
@bear bear merged commit 33c9ccc into bear:master Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants