-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of pdt_locales #130
Conversation
fcdca74
to
3bb60e6
Compare
|
||
locales = ['de_DE', 'en_AU', 'en_US', 'es', 'nl_NL', 'pt_BR', 'ru_RU'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I struggled between the auto-discovering trick and this for a while. But when I realized that as import this
said that "explicit is better than implicit", I thought we should just keep it like this -- simple and stupid -- even it's a bit redundant.
+1 to keeping the locales list very simple and explicit +1 to this PR |
Add pip install -r requirements to travis Move __version__ line to setup.py
Refactoring code
also get all tests passed
ba4e7e6
to
0c1b030
Compare
Current coverage is
|
Just rebased. |
This is suggest refactoring version for issue #124 which intend to remove the redundant pdtLocale classes and init methods.