Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all PyICU test failure #142

Merged
merged 1 commit into from
Nov 7, 2015
Merged

Conversation

philiptzou
Copy link
Collaborator

As the title described. After installing PyICU a lot of test cases are failed. This patch fixed all the test cases and added 3 environments to Travis CI for testing circumstances of different Python versions when PyICU is installed.

But we'll skip PyPy with PyICU since PyICU causes segment fault.

@philiptzou philiptzou force-pushed the pull-request-icu-test branch 2 times, most recently from 50bc349 to 95dcdf5 Compare November 6, 2015 21:18
@philiptzou philiptzou force-pushed the pull-request-icu-test branch from 95dcdf5 to ae04ff7 Compare November 6, 2015 21:19
@codecov-io
Copy link

Current coverage is 77.09%

Merging #142 into master will increase coverage by +3.50% as of 4b3f849

@@            master    #142   diff @@
======================================
  Files           14      14       
  Stmts         1545    1554     +9
  Branches       292     294     +2
  Methods          0       0       
======================================
+ Hit           1137    1198    +61
- Partial         92      93     +1
+ Missed         316     263    -53

Review entire Coverage Diff as of 4b3f849

Powered by Codecov. Updated on successful CI builds.

@bear
Copy link
Owner

bear commented Nov 7, 2015

nicely done!

bear added a commit that referenced this pull request Nov 7, 2015
@bear bear merged commit cd5847e into bear:master Nov 7, 2015
@philiptzou philiptzou deleted the pull-request-icu-test branch November 7, 2015 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants