Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint errors for flake8 v3.5.0 #224

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Fix lint errors for flake8 v3.5.0 #224

merged 1 commit into from
Nov 19, 2019

Conversation

drewcm
Copy link

@drewcm drewcm commented Dec 23, 2017

Fixes parsedatetime lint errors for flake8 v3.5.0 (mccabe: 0.6.1, pycodestyle: 2.3.1, pyflakes: 1.6.0). Required to be fixed before tests will run. The nl_NL.py error references "different values" for 'vorige' key, but to my eye they are the same.

$ make test
flake8 parsedatetime > violations.flake8.txt
Makefile:54: recipe for target 'lint' failed
make: *** [lint] Error 1
$ cat violations.flake8.txt
parsedatetime/pdt_locales/icu.py:141:5: E741 ambiguous variable name 'l'
parsedatetime/pdt_locales/nl_NL.py:74:5: F601 dictionary key 'vorige' repeated with different values
parsedatetime/pdt_locales/nl_NL.py:80:5: F601 dictionary key 'vorige' repeated with different values
$ flake8 --version
3.5.0 (mccabe: 0.6.1, pycodestyle: 2.3.1, pyflakes: 1.6.0) CPython 3.5.2 on Linux
$ git rev-parse HEAD
830775dc5e36395622b41f12317f5e10c303d3a2

Link to code in question:


This change is Reviewable

@bear bear merged commit 5d33f9a into bear:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants