Add a constant for start hour #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s when self.StartTimeFromSourceTime is False. By default it is 9 (am), as was used before.
|
facing the same issue, this should be merged. |
bear
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a constant specifying the start hour for all relative calculations when self.StartTimeFromSourceTime is False.
parsedatetime uses 09:00 as the start of the day for relative calculations, but that time is not currently configurable. 09:00 is the traditional start of the workday in the the US and other countries, but in many countries 07:00 or 08:00 is traditional.
There's also a use case for being able to set the start of the day to 00:00:00.
I considered adding configuration to set hour/minute/second, but thought just hour would satisfy most use cases and require less code change.
This change is