Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make system is broke. #2

Open
EvanCarroll opened this issue Dec 5, 2017 · 0 comments
Open

Make system is broke. #2

EvanCarroll opened this issue Dec 5, 2017 · 0 comments

Comments

@EvanCarroll
Copy link

EvanCarroll commented Dec 5, 2017

This doesn't actually work for me,

ifeq ($(PG91),yes)                                                  
#STUFF CUT OUT...
DATA = $(wildcard sql/*--*.sql) sql/$(EXTENSION)--$(EXTVERSION).sql 
## STUFF
endif                                                               

By that I mean it generates the error

/usr/bin/install: will not overwrite just-created '/usr/share/postgresql/9.5/extension/bignum--0.8.0.sql' with './/sql/bignum--0.8.0.sql'
/usr/lib/postgresql/9.5/lib/pgxs/src/makefiles/pgxs.mk:114: recipe for 
target 'install' failed
make: *** [install] Error 1

Adding some debug $(info $$DATA is [$(DATA)]) in ifeq ($(PG91),yes) I see

$DATA is [sql/bignum--0.8.0.sql sql/bignum--0.8.0.sql]

And, that's what we're setting it too

DATA = $(wildcard sql/*--*.sql) sql/$(EXTENSION)--$(EXTVERSION).sql

That causes bignum--0.8.0.sql to be copied twice to the same location which triggers this error. Can we please just nuke the 9.1 stuff: 9.1 and 8.x are no longer supported, this isn't needed nor is it worth the added complexity.

You can see this pattern here. I think you copied it wrong. In their pg91 section they only have

DATA = $(wildcard sql/*--*.sql)
EvanCarroll added a commit to EvanCarroll/pg-bignum that referenced this issue Dec 9, 2017
* The build system previously was broke, files were attempting to be
  copied twice fouling make. See issue beargiles#2 on github.

* We didn't currently have a method of converting hex to bignum, added.

* Also fixed freeing in the event of length mismatch, believe this was a
  memory leak.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant