-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow arena to work as a node module alongside auth middleware. #123
base: master
Are you sure you want to change the base?
Conversation
…ddleware is needed.
I'm looking forward to this |
|
||
app.use(app.locals.appBasePath, express.static(path.join(__dirname, 'public'))); | ||
app.use(app.locals.appBasePath, routes); | ||
app.locals.mountPath = listenOpts.mountPath || app.locals.basePath; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I'm reading this incorrectly, you intended for this to be listenOpts.mountPath || app.locals.appBasePath;
, right?
Any updates on this? |
I have no idea why it is not merged yet.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been a long-requested feature. I'd like to move this along, but still don't have a ton of time to review. I don't immediately understand the distinction between the appBasePath
and the mountPath
. Along those lines, could we get some documentation in the readme describing how the new option functions and how it differs from the old?
Merging #182 into this. |
I have been unable to find a way to add arena to an existing express app while also implementing authentication. The basePath parameter conflicts with any path other than "/" provided to express' use method. Allowing users to provide a new parameter called "mountPath" can alleviate this issue and allow configs like the following to work:
where basicAuth = https://github.com/expressjs/basic-auth-connect