Importer: interactive option to show other releases from the same release group #3171
Comments
sampsyo
added
the
needinfo
|
Can you please include your configuration and verbose output, as requested by the issue template? Beets should be including all the releases (it doesn't group them by release group). It's possible that your configuration is filtering out the video versions. |
I'm really sorry about that. Since my Checking the verbose output, I don't think there's a problem in this package: it found 10 tracks and the first release with 10 tracks it got from musicbrainz it used for matching... Makes perfect sense actually. Am I supposed to read https://beets.readthedocs.io/en/v1.4.7/reference/config.html#autotagger-matching-options and play with the parameters? I've created the album structure above, using random noise 5s mp3 generated from I still think, if possible, a "(see all versions of this release, X available)" option to be useful. |
|
I see! Thanks for investigating a little bit. It does seem like the issue might be that beets is searching for releases with 10 tracks, which is ordinarily a good idea but here is excluding the other releases that have non-audio tracks that won't be used anyway. That's a little strange! I wish it were possible to search by the number of audio tracks, but I don't think that's a thing. Maybe it would be worth validating this hypothesis by looking into how the search results change if the track length is not included? If you're feeling particularly intrepid, the place to start hacking around with that would be modifying the You mentioned an option to show other releases from the same release group, which is interesting—we could consider adding that as one of the interactive options. That would launch a new search for all the releases in the same group as the current release. |
The example I'm showing you is the album with random mp3 I created to test the hypothesis, but it gives the same result as the original. The only difference is that When you say 424 tracks = None
425 if tracks is not None:And the result was actually worse. So I started to think: is the search done in beets really the same as in the browser like in https://musicbrainz.org/search?query=garden+of+the+titans&type=release&method=indexed? Comparing this url and the beets query, 424 tracks = None
425 criteria['type'] = 'release'
426 if tracks is not None:And keeping But if I add I can't tell you exactly why this happens. I think it's a job for those that are more familiar with these libraries. That's why I'm adding this issue. I've attached the files of this issue for testing: Opeth - [2018] Garden Of The Titans.zip These aren't the original copyrighted files. These are random noise mp3 I created using ffmpeg with the command:
Exactly. I just don't know how difficult it would be or where it should be put. |
|
Is the label |
|
Ok. Now it's getting funny. I've just tested the attached https://github.com/beetbox/beets/files/2920892/Opeth.-.2018.Garden.Of.The.Titans.zip file: Abort and run again I can't write a script trying to simulate this, since |
|
That's very tricky! Thank you for all the extra digging! I'm surprised that including And I'm also mystified by the nondeterminism!!! I will absolutely need to look into that, but is there any chance the nondeterminism is on the MusicBrainz side? That is, that the search returns slightly different results each time? I tend to leave the |
|
I suggest you to try the attached zip and see if you can simulate what I did. I really don't know if this is a musicbrainz issue or a beets one. Indeed, we have multiple stuff on this issue.
Fair enough. |
|
I can confirm that the MusicBrainz search server is acting nondeterministically. If you run this command: And then wait a few moments and do it again, you get different results. In my experience, if you do it twice really fast, then you get the same results, but if you wait for 10 or 20 seconds, the next result is indeed different. That's certainly surprising! I don't precisely know what to do next, but maybe we should see if this is a known issue for the MusicBrainz developers? |
|
@sampsyo I suggest you creating it instead of me since you're more familiar with the code. |
|
I wish that were true. :) I don't have that much familiarity with the MusicBrainz server code. Maybe the first thing to do—and it would be great to have your help with this too—would be to ask around on the MusicBrainz IRC channel to see if there are any search server developers there. They might be able to give you a quick "gut check" on whether nondeterminism seems like a normal/expected behavior. |
|
After reading https://musicbrainz.org/doc/Communication/IRC just went to https://webchat.freenode.net/?channels=musicbrainz,metabrainz: Here is the bash: #!/usr/bin/env bash
url='http://musicbrainz.org/ws/2/release/?limit=5&query=release%3A%28garden+of+the+titans%29+artist%3A%28opeth%29+tracks%3A%2810%29'
for (( i = 0; i < 10; i++ )); do
curl "$url" > "$(date '+%Y-%m-%d-%H-%M-%S')-$RANDOM.xml"
done
sleep 10
curl "$url" > "$(date '+%Y-%m-%d-%H-%M-%S')-$RANDOM.xml"
sleep 20
curl "$url" > "$(date '+%Y-%m-%d-%H-%M-%S')-$RANDOM.xml"
sleep 30
curl "$url" > "$(date '+%Y-%m-%d-%H-%M-%S')-$RANDOM.xml"
Can you try to improve it to be able to simulate what's in #3171 (comment) so we can go back do IRC and ask the developers? Because I couldn't create different results... |
Can you qualify what the different results are/were? As given in the IRC log snippet @msdos gave above, the only difference I can spot (with my eye) is different timestamps in the |
|
@sampsyo can you help us here? |
|
This is super weird, but I can no longer reproduce the nondeterminism! Neither in a beets search nor with isolated @msdos, are you still able to observe nondeterminism when you import that album? |
Funny. I can't reproduce it anymore. But the suggestion of multiple releases still apply. |
sampsyo
changed the title
sampsyo
added
feature
|
Sounds good! Retitled this as a feature request. |
I have an album called
Opeth - Garden Of The Titans. This comes from a blu-ray with 2 CDs. They are on musicbrainz as well:https://musicbrainz.org/release/bf3f9954-c048-4353-ae57-6160ab56d4b5
The original tags from the mp3s have a discnumber tag:
When I try to import this album to
beets, this comes from Musicbrainz:It's getting the digital release instead of the Blu-ray + 2 CDs.
If you search for "Garden of the Titans" in musicbrainz interface, you get 3 releases:
But when searching like I did in the beginning of this issue,
beetsonly get one release:Do we have a difference in the website search and musicbrainz API? Is this a musicbrainz or beets issue? How it decided that the best option was the digital download instead of the 2xCD since I have the discnumber tag in my mp3s?
Can we add support in Musicbrainz for
(see all versions of this release, X available)similar to what you do toMore candidates? There's this option in the (wrong) selected digital release at https://musicbrainz.org/release/c29d1500-04c0-4b59-9744-38eb41905e10, and if I could select other release available in the beets dialog would solve my problem.The text was updated successfully, but these errors were encountered: