Send albuminfo_received / trackinfo_received when running mbsync #2922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send events from {album,track}_for_mbid, then remove the decorators from
{albums,tracks}_for_id so that duplicate events are not fired.
When moving to generators and decorators in autotag.hooks (#2249),
albuminfo_received and trackinfo_received stopped being sent from code
directly calling hooks.{album,track}_for_mbid. This is most visible when
trying to write a plugin to interact with mbsync, as the documentation
explicitly says it should work.
|
Perfect! Thank you for the thoughtful investigation and the clean fix. 👍 ✨ 🐟 🚀 🍰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2921, and adds a test case to hopefully help future refactors of autotag.hooks not break mbsync events.
I don't think completely removing
@plugins.notify_info_yieldedis the right thing here, it works really well foralbum_candidates/item_candidates.