-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
discogs_client version check #4698
Conversation
Hi @ghbrown, thank you very much for the PR, this is great! I am only wondering if we should, while we are at it, require an even higher version. I just recalled that we had reports that came out of the beets community about a bytes vs str error around a year ago: joalla/discogs_client#80 It took us a while to fix it but we did in this PR: joalla/discogs_client#94 It was released in 2.3.15: https://github.com/joalla/discogs_client/releases/tag/v2.3.15 |
Looked through release notes and I don't see a reason why 2.3.15 minimum could be problematic. Also please increase the version requirement of python3-discogs-client in |
Sounds good!! |
@@ -111,7 +111,7 @@ def build_manpages(): | |||
'requests_oauthlib', | |||
'reflink', | |||
'rarfile', | |||
'python3-discogs-client', | |||
'python3-discogs-client>=2.3.15', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the requested changes and also added a minimum version for the extras_require 'test'
in setup.py
. Not sure why there wasn't one before, but if there's a reason I'm happy to revert.
That seems like a very good idea. Thank you!! |
Description
Addresses #4691, providing a warning if the user attempts to use a non-compliant version of
discogs_client
(any version of the abandoned packagediscogs-client
orpython3-discogs-client
< 2.3.10). These non-compliant versions give no error when runningbeet import
, but instead manifest as a large number ofNo matching records found
due to rate limiting (which is expected to be implemented bydiscogs_client
).To Do
docs/
to describe it.)docs/changelog.rst
near the top of the document.)